feat: allow peek view to be closed by the caller && bump bs #8542

pengx17 · 2024-10-18T06:12:46Z

depends on toeverything/blocksuite#8558
fix BS-1570

graphite-app · 2024-10-18T06:12:53Z

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

pengx17 · 2024-10-18T06:13:01Z

feat(core): pdf preview #8569 : 6 dependent PRs (#8615 , #8671 , #8720 and 3 others)
feat: allow peek view to be closed by the caller && bump bs #8542 👈 (View in Graphite)
canary

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

nx-cloud · 2024-10-18T06:13:21Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 001eacc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

nx test:coverage @affine/monorepo

Sent with 💌 from NxCloud.

codecov · 2024-10-18T06:17:26Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.17%. Comparing base (3f7752e) to head (81029db).
Report is 1 commits behind head on canary.

Additional details and impacted files

@@           Coverage Diff           @@
##           canary    #8542   +/-   ##
=======================================
  Coverage   70.17%   70.17%           
=======================================
  Files         536      536           
  Lines       33700    33700           
  Branches     3023     3023           
=======================================
  Hits        23648    23648           
  Misses       9697     9697           
  Partials      355      355

Flag	Coverage Δ
server-test	`77.08% <ø> (ø)`
unittest	`45.31% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

graphite-app · 2024-10-28T09:15:47Z

Merge activity

Oct 28, 5:15 AM EDT: A user added this pull request to the Graphite merge queue.
Oct 28, 5:32 AM EDT: A user merged this pull request with the Graphite merge queue.

depends on toeverything/blocksuite#8558 fix BS-1570

github-actions bot added the app:core label Oct 18, 2024

pengx17 marked this pull request as ready for review October 18, 2024 06:22

graphite-app bot requested review from EYHN, forehalo, CatsJuice and JimmFly October 18, 2024 06:22

EYHN approved these changes Oct 21, 2024

View reviewed changes

pengx17 force-pushed the 10-18-feat_blocks_allow_peek_view_to_be_closed_by_the_caller branch from 86dfa0e to d1c295d Compare October 21, 2024 09:31

pengx17 temporarily deployed to canary October 21, 2024 09:31 — with GitHub Actions Inactive

fundon force-pushed the 10-18-feat_blocks_allow_peek_view_to_be_closed_by_the_caller branch from d1c295d to f8f786b Compare October 22, 2024 09:05

fundon mentioned this pull request Oct 22, 2024

feat(core): pdf preview #8569

Merged

2 tasks

fundon temporarily deployed to canary October 22, 2024 09:06 — with GitHub Actions Inactive

pengx17 force-pushed the 10-18-feat_blocks_allow_peek_view_to_be_closed_by_the_caller branch from f8f786b to 03cb2c8 Compare October 22, 2024 10:30

pengx17 had a problem deploying to canary October 22, 2024 10:30 — with GitHub Actions Failure

github-actions bot added the mod:i18n Related to i18n label Oct 22, 2024

fundon force-pushed the 10-18-feat_blocks_allow_peek_view_to_be_closed_by_the_caller branch from 03cb2c8 to a459499 Compare October 22, 2024 23:55

fundon had a problem deploying to canary October 22, 2024 23:55 — with GitHub Actions Failure

pengx17 force-pushed the 10-18-feat_blocks_allow_peek_view_to_be_closed_by_the_caller branch from a459499 to 879aac4 Compare October 25, 2024 04:43

pengx17 temporarily deployed to canary October 25, 2024 04:43 — with GitHub Actions Inactive

doouding force-pushed the 10-18-feat_blocks_allow_peek_view_to_be_closed_by_the_caller branch from 879aac4 to b4af76f Compare October 25, 2024 06:46

doouding temporarily deployed to canary October 25, 2024 06:47 — with GitHub Actions Inactive

github-actions bot added mod:infra Environment related issues and discussions mod:env mod:component app:electron Related to electron app mod:dev labels Oct 25, 2024

doouding temporarily deployed to canary October 28, 2024 03:01 — with GitHub Actions Inactive

doouding temporarily deployed to canary October 28, 2024 03:08 — with GitHub Actions Inactive

pengx17 force-pushed the 10-18-feat_blocks_allow_peek_view_to_be_closed_by_the_caller branch from 94ae12e to 52c2740 Compare October 28, 2024 05:07

pengx17 temporarily deployed to canary October 28, 2024 05:07 — with GitHub Actions Inactive

fundon force-pushed the 10-18-feat_blocks_allow_peek_view_to_be_closed_by_the_caller branch from 52c2740 to 34844fe Compare October 28, 2024 06:33

fundon temporarily deployed to canary October 28, 2024 06:33 — with GitHub Actions Inactive

fundon mentioned this pull request Oct 28, 2024

chore: improve pdf preview #8615

Merged

7 tasks

doouding force-pushed the 10-18-feat_blocks_allow_peek_view_to_be_closed_by_the_caller branch from 34844fe to 001eacc Compare October 28, 2024 08:18

doouding temporarily deployed to canary October 28, 2024 08:19 — with GitHub Actions Inactive

doouding temporarily deployed to canary October 28, 2024 08:34 — with GitHub Actions Inactive

doouding temporarily deployed to canary October 28, 2024 08:41 — with GitHub Actions Inactive

feat: allow peek view to be closed by the caller && bump bs (#8542)

81029db

depends on toeverything/blocksuite#8558 fix BS-1570

EYHN force-pushed the 10-18-feat_blocks_allow_peek_view_to_be_closed_by_the_caller branch from 001eacc to 81029db Compare October 28, 2024 09:16

EYHN temporarily deployed to canary October 28, 2024 09:17 — with GitHub Actions Inactive

graphite-app bot merged commit 81029db into canary Oct 28, 2024
39 checks passed

graphite-app bot deleted the 10-18-feat_blocks_allow_peek_view_to_be_closed_by_the_caller branch October 28, 2024 09:32

graphite-app bot temporarily deployed to canary October 28, 2024 09:33 Inactive

This was referenced Nov 1, 2024

feat(core): pdf embed view component #8671

Open

feat: pdf module #8720

Merged

This was referenced Nov 10, 2024

refactor: pdf viewer using op and service #8764

Merged

refactor: pdf viewer components #8774

Closed

forehalo mentioned this pull request Nov 11, 2024

refactor(core): patch pdf viewer #8782

Merged

This was referenced Nov 11, 2024

refactor: pdf viewer components #8784

Merged

feat(core): pdf viewer supports fit to page #8812

Open

fundon mentioned this pull request Dec 25, 2024

feat(core): add pdf preview feature flag #9307

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: allow peek view to be closed by the caller && bump bs #8542

feat: allow peek view to be closed by the caller && bump bs #8542

pengx17 commented Oct 18, 2024 •

edited

Loading

graphite-app bot commented Oct 18, 2024

pengx17 commented Oct 18, 2024 •

edited by fundon

Loading

nx-cloud bot commented Oct 18, 2024 •

edited

Loading

codecov bot commented Oct 18, 2024 •

edited

Loading

graphite-app bot commented Oct 28, 2024 •

edited

Loading

feat: allow peek view to be closed by the caller && bump bs #8542

feat: allow peek view to be closed by the caller && bump bs #8542

Conversation

pengx17 commented Oct 18, 2024 • edited Loading

graphite-app bot commented Oct 18, 2024

Your org has enabled the Graphite merge queue for merging into canary

pengx17 commented Oct 18, 2024 • edited by fundon Loading

How to use the Graphite Merge Queue

nx-cloud bot commented Oct 18, 2024 • edited Loading

☁️ Nx Cloud Report

codecov bot commented Oct 18, 2024 • edited Loading

Codecov Report

graphite-app bot commented Oct 28, 2024 • edited Loading

Merge activity

pengx17 commented Oct 18, 2024 •

edited

Loading

pengx17 commented Oct 18, 2024 •

edited by fundon

Loading

nx-cloud bot commented Oct 18, 2024 •

edited

Loading

codecov bot commented Oct 18, 2024 •

edited

Loading

graphite-app bot commented Oct 28, 2024 •

edited

Loading